Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with page and app router #87

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

marcospassos
Copy link
Member

Summary

This PR addresses two issues:

Compatibility with next/dist imports: In certain applications, the SDK could not import classes from next/dist. To resolve this, the logic has been moved directly into the SDK.
Hook compatibility with App Router: The hook was failing when used with the App Router because it was relying on the useRouter implementation compatible only with the Page Router. This has been updated to properly check and ensure compatibility, preventing errors.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the bug Something isn't working label Nov 21, 2024
Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@croct/plug-next@87

commit: ed22786

@marcospassos marcospassos merged commit b6cc9dd into master Nov 21, 2024
8 checks passed
@marcospassos marcospassos deleted the fix-compatibility branch November 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant